Support grouped choices. #3225
Merged
Support grouped choices. #3225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adds support for mixing single and paired choices:
```
[
('poor', 'Poor quality'),
'medium',
('good', 'Good quality'),
]
```
…django-rest-framework into maxpeterson-grouped-choices-fix
|
@maxpeterson - We could consider something like #3101 as a follow up to this. I chose not to push that in as part of this change as a consequence of it being unclear what behavior we'd want (or even if we do want that behavior). As you mentioned:
I think the bottom line might be that we wouldn't accept further complications to the already ad-hoc 'OPTIONS' behavior, however I'd be willing to consider a fresh ticket for it if you were so minded and wanted to discuss further. |
tomchristie
added a commit
that referenced
this pull request
Aug 6, 2015
…-fix Support grouped choices.
This was referenced Mar 9, 2017
This was referenced Oct 16, 2017
This was referenced Nov 6, 2017
This was referenced Nov 14, 2017
This was referenced Dec 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the work in #3108 from @maxpeterson - Thank you!
Closes #1533.
Renders as: